workspace: Remove tweens when hiding overlays

The window overlays may be shown erroneously if hideOverlays is
called while the corresponding clone has an uncompleted tween which
calls showOverlays in its onComplete handler, for instance when
quickly leaving the overview before the initial overview animation
has finished. To fix, remove all existing tweens when hiding the
overlays.

https://bugzilla.gnome.org/show_bug.cgi?id=666020

diff --git a/js/ui/workspace.js b/js/ui/workspace.js
index 431d184b5fb81eadfe9d9242393dd4e97154542d..b618bb6c25ee7628de671ac6d5f69d8f953378d6 100644 (file)
--- a/js/ui/workspace.js
+++ b/js/ui/workspace.js
@@ -1130,6 +1130,8 @@ const Workspace = new Lang.Class({
 
     _hideAllOverlays: function() {
         for (let i = 0; i < this._windows.length; i++) {
+            let clone = this._windows[i];
+            Tweener.removeTweens(clone.actor);
             let overlay = this._windowOverlays[i];
             if (overlay)
                 overlay.hide();